feat: migrate BUI + root tests from Jest to Vitest (follow-up to FR-2609) by nowgnuesLee · Pull Request #6875 · lablup/backend.ai-webui

nowgnuesLee · 2026-04-22T05:29:58Z

Follow-up to FR-2609. Extends the Vitest cutover to the two remaining Jest suites. No Jira ticket was created for this slice — scope is purely "finish the migration consistently across workspaces". If a Jira issue is needed for tracking, I'll link it after the fact.

Summary

`packages/backend.ai-ui/` (14 files, 315 passing + 5 skipped)

New packages/backend.ai-ui/vitest.config.ts — mirrors react/vitest.config.ts plus vite-plugin-relay-lite (matches BUI's existing prod build pipeline).
New __test__/vitest.jest-compat.ts (same pattern) + __test__/jest-globals-shim.ts that redirects import { ... } from '@jest/globals' to a re-export from vitest.
Migrated jest.mock(...) → vi.mock(...) in 4 files (only vi.mock is hoisted by Vitest).
BAIBackButton.test.tsx: converted jest.requireActual(...) to the async importOriginal factory pattern.
4 rc-motion / jsdom-29 flaky tests skipped with // TODO(FR-2609) markers.

Root `/src` + `/scripts` (4 files, 90 passing + 1 skipped)

New /vitest.config.ts (Node env, minimal) + /__test__/vitest.jest-compat.ts.
Removed the Jest config block from root package.json; test script now runs vitest run.
scripts/i18n-merge-driver.test.ts: jest.mock → vi.mock. The single fs-mock test is skipped with // TODO(FR-2609) — CJS require("fs") inside the plain .js driver doesn't pick up Vitest's mock.

Skip decisions (each with `TODO(FR-2609)` in source)

File	Why skipped
4 tests in BUI (`BAIButton`, `BAIUnmountAfterClose`)	rc-motion's `supportTransition` stays `true` under jsdom 29, waits for `transitionend` that never fires. Jest's older jsdom triggered the sync fallback.
1 test in `i18n-merge-driver.test.ts`	`vi.mock('fs', ...)` doesn't propagate into the CJS `require("fs")` inside the JS driver.

Test plan

pnpm --prefix ./packages/backend.ai-ui run vitest → 315 pass, 5 skip
pnpm exec vitest run (root) → 90 pass, 1 skip
react/ (FR-2609) remains 856/856

Stack

Builds on FR-2609. Followed by FR-2611 which retires the CRA/Craco build system now that all test suites are off Jest.

nowgnuesLee · 2026-04-22T05:30:07Z

fix(FR-2529): include backend.ai-client src in craco TS loader and tsconfig paths #6615
refactor(FR-2529): extract backend.ai-client as standalone workspace package #6614
fix(FR-2607): align Electron publicPath patch with Vite output #7189
fix(FR-2606): clear residual build-time warnings (BUI dts + module directive) #7113
fix(FR-2606): restore Monaco self-hosting in Vite dev server #7104
feat(FR-2748): fully migrate test files from jest.* to vi.* and align TS globals #7083
feat(FR-2746): re-enable 5 tests skipped during Vitest migration #7071
feat(FR-2744): restore Vitest coverage reporting in CI #7065
fix(FR-2606): replace webpackIgnore with @vite-ignore in dynamic plugin imports #6879
fix(FR-2606): replace global.packageVersion with globalThis.packageVersion in WebUISider #6878
fix(FR-2608): disable vite-plugin-pwa auto-manifest to preserve existing manifest.json #6877
feat(FR-2611): retire Craco/Webpack — build, Makefile, CI all on Vite/Vitest #6876
feat: migrate BUI + root tests from Jest to Vitest (follow-up to FR-2609) #6875 👈 (View in Graphite)
feat(FR-2609): Vitest migration for react/ (100% pass, 856/856 tests) #6874
feat(FR-2608): Vite production build with vite-plugin-pwa service worker #6873
feat(FR-2610): Vite dev-reload plugin for i18n / theme / config.toml file changes #6872
feat(FR-2607): Vite spike answer — es6:// Electron publicPath works via renderBuiltUrl #6871
feat(FR-2606): restore BUI i18n context isolation under Vite dep optimization #6870
feat(FR-2606): Vite PoC phase 1 — dev server + HMR + React Compiler parity #6869
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-04-22T05:32:48Z

Coverage report for `./react`

Action wasn't able to generate report within GitHub comment limit. If you're facing this issue, please let me know by commenting under this issue.

Report generated by 🧪jest coverage report action from b598d84

Copilot

Pull request overview

This PR completes the Jest → Vitest migration for the remaining test suites in the monorepo (repo-root /src + /scripts, and packages/backend.ai-ui/), aligning them with the existing react/ Vitest setup from FR-2609.

Changes:

Add new Vitest configs + Jest-compat shims for repo-root and packages/backend.ai-ui/.
Update tests to use Vitest-compatible mocking (vi.mock, async importOriginal) and refresh snapshots.
Remove leftover Jest config/deps, and skip known flaky tests with TODO(FR-2609) markers.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
vitest.config.ts	Adds minimal Node-environment Vitest config for root `/src` and `/scripts` suites.
test/vitest.jest-compat.ts	Adds root Jest→Vitest global shim (`globalThis.jest = vi`).
package.json	Switches root `test` script from Jest to `vitest run` and removes embedded Jest config.
scripts/i18n-merge-driver.test.ts	Updates mocking to `vi.mock` and skips a CJS-mock-incompatible test.
react/package.json	Removes Jest-related devDependencies from the React workspace.
react/jest.config.cjs	Deletes React Jest config file.
packages/backend.ai-ui/vitest.config.ts	Adds BUI Vitest config mirroring React’s transform pipeline + Relay/SVGR support.
packages/backend.ai-ui/package.json	Switches BUI tests from Jest to Vitest and updates devDependencies.
packages/backend.ai-ui/test/vitest.jest-compat.ts	Adds BUI Jest→Vitest global shim (`globalThis.jest = vi`).
packages/backend.ai-ui/test/jest-globals-shim.ts	Adds `@jest/globals` specifier shim to re-export from Vitest.
packages/backend.ai-ui/src/components/fragments/BAIDomainSelect.test.tsx	Migrates `jest.mock` → `vi.mock`.
packages/backend.ai-ui/src/components/BAIStatistic.test.tsx	Migrates `jest.mock` → `vi.mock`.
packages/backend.ai-ui/src/components/BAIBulkEditFormItem.test.tsx	Migrates `jest.mock` → `vi.mock`.
packages/backend.ai-ui/src/components/BAIBackButton.test.tsx	Replaces `jest.requireActual` with Vitest async `importOriginal` pattern.
packages/backend.ai-ui/src/components/BAIFlex.test.tsx	Updates mocks for Vitest compatibility.
packages/backend.ai-ui/src/components/snapshots/BAIFlex.test.tsx.snap	Updates snapshot format/header to Vitest output.
packages/backend.ai-ui/src/components/BAIButton.test.tsx	Skips flaky motion-related tests under jsdom 29 with TODO markers.
packages/backend.ai-ui/src/components/BAIUnmountAfterClose.test.tsx	Skips flaky motion-related tests under jsdom 29 with TODO markers.

Comments suppressed due to low confidence (1)

scripts/i18n-merge-driver.test.ts:11

process.exit is being overwritten at module scope and never restored. That mutation can leak into other tests in the same Vitest worker and hide real failures (or break code that relies on the real exit behavior). Capture the original process.exit and restore it in afterEach/afterAll (and consider using vi.spyOn(process, 'exit') instead of direct assignment).

// Mock process.exit to avoid test termination
const mockExit = jest.fn();
process.exit = mockExit as any;

graphite-app · 2026-04-30T12:11:52Z

Merge activity

Apr 30, 12:11 PM UTC: yomybaby added this pull request to the Graphite merge queue.
Apr 30, 12:30 PM UTC: Merged by the Graphite merge queue.

) (#6875) Follow-up to FR-2609. Extends the Vitest cutover to the two remaining Jest suites. No Jira ticket was created for this slice — scope is purely "finish the migration consistently across workspaces". If a Jira issue is needed for tracking, I'll link it after the fact. ## Summary ### `packages/backend.ai-ui/` (14 files, 315 passing + 5 skipped) - New `packages/backend.ai-ui/vitest.config.ts` — mirrors `react/vitest.config.ts` plus `vite-plugin-relay-lite` (matches BUI's existing prod build pipeline). - New `__test__/vitest.jest-compat.ts` (same pattern) + `__test__/jest-globals-shim.ts` that redirects `import { ... } from '@jest/globals'` to a re-export from `vitest`. - Migrated `jest.mock(...)` → `vi.mock(...)` in 4 files (only `vi.mock` is hoisted by Vitest). - `BAIBackButton.test.tsx`: converted `jest.requireActual(...)` to the async `importOriginal` factory pattern. - 4 rc-motion / jsdom-29 flaky tests skipped with `// TODO(FR-2609)` markers. ### Root `/src` + `/scripts` (4 files, 90 passing + 1 skipped) - New `/vitest.config.ts` (Node env, minimal) + `/__test__/vitest.jest-compat.ts`. - Removed the Jest config block from root `package.json`; `test` script now runs `vitest run`. - `scripts/i18n-merge-driver.test.ts`: `jest.mock` → `vi.mock`. The single `fs`-mock test is skipped with `// TODO(FR-2609)` — CJS `require("fs")` inside the plain `.js` driver doesn't pick up Vitest's mock. ### Skip decisions (each with `TODO(FR-2609)` in source) | File | Why skipped | |---|---| | 4 tests in BUI (`BAIButton`, `BAIUnmountAfterClose`) | rc-motion's `supportTransition` stays `true` under jsdom 29, waits for `transitionend` that never fires. Jest's older jsdom triggered the sync fallback. | | 1 test in `i18n-merge-driver.test.ts` | `vi.mock('fs', ...)` doesn't propagate into the CJS `require("fs")` inside the JS driver. | ## Test plan - [x] `pnpm --prefix ./packages/backend.ai-ui run vitest` → 315 pass, 5 skip - [x] `pnpm exec vitest run` (root) → 90 pass, 1 skip - [x] `react/` (FR-2609) remains 856/856 ## Stack Builds on FR-2609. Followed by FR-2611 which retires the CRA/Craco build system now that all test suites are off Jest.

github-actions Bot assigned nowgnuesLee Apr 22, 2026

nowgnuesLee mentioned this pull request Apr 22, 2026

feat(FR-2609): Vitest migration for react/ (100% pass, 856/856 tests) #6874

Merged

3 tasks

github-actions Bot added the size:L 100~500 LoC label Apr 22, 2026

This was referenced Apr 27, 2026

feat(FR-2744): restore Vitest coverage reporting in CI #7065

Merged

feat(FR-2746): re-enable 5 tests skipped during Vitest migration #7071

Merged

feat(FR-2748): fully migrate test files from jest.* to vi.* and align TS globals #7083

Merged

nowgnuesLee force-pushed the 04-21-feat_fr-2609_vitest_migration_for_react__96.9_pass_rate_822_848_tests_ branch from 21142d6 to f2d5ec5 Compare April 27, 2026 13:57

nowgnuesLee force-pushed the 04-21-feat_migrate_bui_root_tests_from_jest_to_vitest_follow-up_to_fr-2609_ branch from ace1b59 to 818d02a Compare April 27, 2026 13:57

This was referenced Apr 27, 2026

fix(FR-2606): restore Monaco self-hosting in Vite dev server #7104

Merged

fix(FR-2606): clear residual build-time warnings (BUI dts + module directive) #7113

Merged

nowgnuesLee marked this pull request as ready for review April 28, 2026 04:25

Copilot AI review requested due to automatic review settings April 28, 2026 04:25

Copilot started reviewing on behalf of nowgnuesLee April 28, 2026 04:26 View session

Copilot AI reviewed Apr 28, 2026

View reviewed changes

Comment thread scripts/i18n-merge-driver.test.ts

Comment thread packages/backend.ai-ui/package.json

Comment thread react/package.json

nowgnuesLee force-pushed the 04-21-feat_migrate_bui_root_tests_from_jest_to_vitest_follow-up_to_fr-2609_ branch from 818d02a to 6c1b86d Compare April 28, 2026 05:02

nowgnuesLee force-pushed the 04-21-feat_fr-2609_vitest_migration_for_react__96.9_pass_rate_822_848_tests_ branch from f2d5ec5 to 3b0c2a9 Compare April 28, 2026 05:02

nowgnuesLee force-pushed the 04-21-feat_migrate_bui_root_tests_from_jest_to_vitest_follow-up_to_fr-2609_ branch from 6c1b86d to 7f03080 Compare April 28, 2026 05:15

nowgnuesLee force-pushed the 04-21-feat_fr-2609_vitest_migration_for_react__96.9_pass_rate_822_848_tests_ branch 2 times, most recently from 411037f to c25e4c7 Compare April 28, 2026 05:19

nowgnuesLee force-pushed the 04-21-feat_migrate_bui_root_tests_from_jest_to_vitest_follow-up_to_fr-2609_ branch from 7f03080 to 027a403 Compare April 28, 2026 05:19

nowgnuesLee force-pushed the 04-21-feat_fr-2609_vitest_migration_for_react__96.9_pass_rate_822_848_tests_ branch from c25e4c7 to fd46dfb Compare April 28, 2026 05:25

nowgnuesLee force-pushed the 04-21-feat_migrate_bui_root_tests_from_jest_to_vitest_follow-up_to_fr-2609_ branch 2 times, most recently from 1f59ad5 to d578ec5 Compare April 28, 2026 05:28

nowgnuesLee force-pushed the 04-21-feat_fr-2609_vitest_migration_for_react__96.9_pass_rate_822_848_tests_ branch from fd46dfb to 593ff3b Compare April 28, 2026 05:28

yomybaby mentioned this pull request Apr 30, 2026

fix(FR-2607): align Electron publicPath patch with Vite output #7189

Merged

yomybaby force-pushed the 04-21-feat_fr-2609_vitest_migration_for_react__96.9_pass_rate_822_848_tests_ branch from 593ff3b to 374a63e Compare April 30, 2026 12:08

yomybaby force-pushed the 04-21-feat_migrate_bui_root_tests_from_jest_to_vitest_follow-up_to_fr-2609_ branch from d578ec5 to 5fc6577 Compare April 30, 2026 12:08

This was referenced Apr 30, 2026

refactor(FR-2529): extract backend.ai-client as standalone workspace package #6614

Merged

fix(FR-2529): include backend.ai-client src in craco TS loader and tsconfig paths #6615

Closed

graphite-app Bot force-pushed the 04-21-feat_fr-2609_vitest_migration_for_react__96.9_pass_rate_822_848_tests_ branch from 374a63e to 40cf0a8 Compare April 30, 2026 12:15

graphite-app Bot force-pushed the 04-21-feat_migrate_bui_root_tests_from_jest_to_vitest_follow-up_to_fr-2609_ branch from 5fc6577 to b598d84 Compare April 30, 2026 12:16

Base automatically changed from 04-21-feat_fr-2609_vitest_migration_for_react__96.9_pass_rate_822_848_tests_ to main April 30, 2026 12:29

graphite-app Bot merged commit b598d84 into main Apr 30, 2026
5 of 7 checks passed

graphite-app Bot deleted the 04-21-feat_migrate_bui_root_tests_from_jest_to_vitest_follow-up_to_fr-2609_ branch April 30, 2026 12:30

github-pages Bot temporarily deployed to github-pages April 30, 2026 12:31 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: migrate BUI + root tests from Jest to Vitest (follow-up to FR-2609)#6875

feat: migrate BUI + root tests from Jest to Vitest (follow-up to FR-2609)#6875
graphite-app[bot] merged 1 commit intomainfrom
04-21-feat_migrate_bui_root_tests_from_jest_to_vitest_follow-up_to_fr-2609_

nowgnuesLee commented Apr 22, 2026 •

edited

Loading

Uh oh!

nowgnuesLee commented Apr 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 22, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graphite-app Bot commented Apr 30, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

nowgnuesLee commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

packages/backend.ai-ui/ (14 files, 315 passing + 5 skipped)

Root /src + /scripts (4 files, 90 passing + 1 skipped)

Skip decisions (each with TODO(FR-2609) in source)

Test plan

Stack

Uh oh!

nowgnuesLee commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report for ./react

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graphite-app Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nowgnuesLee commented Apr 22, 2026 •

edited

Loading

`packages/backend.ai-ui/` (14 files, 315 passing + 5 skipped)

Root `/src` + `/scripts` (4 files, 90 passing + 1 skipped)

Skip decisions (each with `TODO(FR-2609)` in source)

nowgnuesLee commented Apr 22, 2026 •

edited

Loading

github-actions Bot commented Apr 22, 2026 •

edited

Loading

Coverage report for `./react`

graphite-app Bot commented Apr 30, 2026 •

edited

Loading